feat(memory): add optional Mem0 backend for skill iteration and reflection tracking#118
feat(memory): add optional Mem0 backend for skill iteration and reflection tracking#118jrauch713-svg wants to merge 1 commit into
Conversation
…ction tracking Wires SkillMemory into ReflACTTrainer via non-breaking hooks: records each step's skill/score after the evaluation gate and each step's reflection patches after the accumulation loop. Degrades to a no-op when MEM0_API_KEY is unset. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@jrauch713-svg please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
Thanks for exploring persistent memory for SkillOpt. Memory can be valuable if retrieval measurably improves training, but the current design is not safe to merge yet. The primary blocker is consent and data handling: merely having a global Other required changes:
The CLA check is also still incomplete. Please rework this in the original PR if you would like to continue; that preserves your authorship while allowing a safe review. We can re-review once explicit consent, privacy controls, tests, and a real retrieval benefit are present. |
Yif-Yang
left a comment
There was a problem hiding this comment.
Requesting changes because the current opt-in and data-handling design can upload private skill and patch content without explicit SkillOpt consent, and the integration lacks tests and a retrieval benefit. Please address the detailed maintainer comment above.
Summary
skillopt/memorybackend that persists skill iterations and reflection patches to Mem0 during training.ReflACTTrainervia non-breaking hooks (maybe_init_mem0,hook_post_evaluate,hook_post_reflect) that no-op whenMEM0_API_KEYis unset.Details
maybe_init_mem0(cfg)is called once before the training loop starts.hook_post_reflectruns after each step's accumulation loop, recording raw patches and aggregate hard/soft scores.hook_post_evaluateruns after the evaluation gate updates the current skill/score.Test plan
python3 -m py_compile skillopt/engine/trainer.pypassesMEM0_API_KEYset to confirm skill iterations land in Mem0